BIP-458: Enable GOLD gauges on Arbitrum #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xeonus
changed the title
Zen-Maxi
reviewed
Oct 19, 2023
There was a problem hiding this comment.
I pushed over this, can see comments in my last push. Create functions for pools and gauges are done outside of payloads because anyone can do them. The only portion you needed was correct, the grant of permissions, setRelativeWeightCap, and revoke. A second json was needed to add new gauges to the controller, via the LM multisig using gaugeAdderV4. We can discuss Friday or this weekend when you have time.
|
BIP validation results for file BIPs/2023-W42/BIP-458B.json: BIP validation results for file BIPs/2023-W43/BIP-458A.json: |
|
File name: BIPs/2023-W42/BIP-458B.json File name: BIPs/2023-W43/BIP-458A.json File name: BIPs/2023-W43/BIP-458A.json |
|
Checked: https://arbiscan.io/address/0xf7c5c26B574063e7b098ed74fAd6779e65E3F836#readContract is a CL rate provider pointed at the cl wstETH/ETH exchange feed. |
Tritium-VLK
previously approved these changes
Oct 21, 2023
- gauge adds missing (needs gauge adder v4) - this payload still needs to be modified
458A - DAO Multisig -reduced to only include the granting of setRelativeWeightCap role, setting Gold pool on Base to 5% cap, and revoking of role. Had to remove create functions, those are permisionless and not needed. Simulation: https://dashboard.tenderly.co/public/safe/safe-apps/simulator/0a864b21-f3b3-4a5a-bff1-6e4c430ef21e 458B - Uses the Maxi LM Multisig to add new gauges created to meet the cap requests. Simulation: https://dashboard.tenderly.co/public/safe/safe-apps/simulator/0a774ec0-f96f-4b6e-be87-0696d8d00150
Tritium-VLK
force-pushed
the
bip-xxx-enable_gold_arbitrum
branch
from
4c251b0
to
a83797d
Compare
|
Reworked the branch, recommited the move of the new branch and force-pushed to clean up touching file from another BIP. |
|
BIP validation results for file BIPs/2023-W42/BIP-458B.json: BIP validation results for file BIPs/2023-W43/BIP-458A.json: |
|
File name: BIPs/2023-W42/BIP-458B.json File name: BIPs/2023-W43/BIP-458A.json File name: BIPs/2023-W43/BIP-458A.json |
Tritium-VLK
approved these changes
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
payload for proposed bip in https://forum.balancer.fi/t/bip-xxx-enable-50gold-25usdc-25wsteth-25gold-25bal-25aura-25wsteth-arbitrum/5262
this does not include the 8%/2% split for the ARB rewards, which is not something that is multisig controlled as i understand